http://crbug.com/22926
You know the funny part? I had hacked that exact thing (in
ChromiumCurrentTime.cpp) locally during work on this bug.
M-A
On Tue, Oct 27, 2009 at 9:53 PM, Albert J. Wong (王重傑)
<ajw...@chromium.org> wrote:
> Would a hack like running nm --defined-only on each generated object, and
> then checking for dups work? You'd have to ignore weak symbols, and
> probably some others, but sounds doable.
> -Albert
>
> On Tue, Oct 27, 2009 at 6:48 PM, Peter Kasting <pkast...@google.com> wrote:
>>
>> On Tue, Oct 27, 2009 at 4:40 PM, James Robinson <jam...@chromium.org>
>> wrote:
>>>
>>> So what's the problem? WTF::currentTime() is implemented twice, once in
>>> JavaScriptCore/wtf/CurrentTime.cpp and once in
>>> webkit/api/src/ChromiumCurrentTime.cpp. The latter simply defers to
>>> base::Time::Now().ToDoubleT(), the former uses a somewhat different
>>> algorithm to try to normalize what the system returns. ThreadTimers.cpp was
>>> linking against the JavaScriptCore/wtf/CurrentTime.cpp version and
>>> webkitclient_impl.cc was linking against the
>>> webkit/api/src/ChromiumCurrentTime.cpp version.
>>
>> Arrrgghhhhhh
>> Is there a way we can compile-time detect similar symbol names like this
>> and throw fits (with a whitelist for any we know are OK)? Seems like this
>> is an issue for something with linking that maruel might have looked at long
>> ago.
>> PKJ
>> >>
>
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
