On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin <ev...@google.com> wrote:
> Since we're talking about style, I'll note that this pattern is no
> good (and I've seen it explicitly called out somewhere before).
>
> The problem is that your assertions are not helpful. You get
> "expected 'foo', got 'bar' on line 80" but line 80 is just the body of
> a for loop.
(a) I frequently write EXPECT_EQ(a, b) << "Test case in question is " << c;
(b) Even when this is not true it costs me almost no time to track down the
case in question in the debugger (if I need to; often the expected result is
unique)
Don't assume what is and is not helpful to me.
PK
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
