On Wed, Dec 9, 2009 at 3:48 PM, John Abd-El-Malek <j...@chromium.org> wrote:
> Lately I've been seeing more and more // NOLINT added to the code. It's
> great that people are running lint to make sure that they're following the
> guidelines, but I personally find adding comments or gibberish to our code
> for tools that are supposed to make the code quality better happy/more
> consistent a bit ironic. I also find it distracting when reading the code.
> Am I the only one?
You are not. We should prefer linter errors to // NOLINT comments, because
we should prefer to optimize code readability at the expense of reviewers
making more judgment calls, and these comments are definitely visual noise
that detracts from readability.
I support an immediate s/\/\/\ NOLINT//g.
PK
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
