I have a checkin ready: http://codereview.chromium.org/547021
Right now it checks the version, but please let me know if you think it would be better to just check *gold*2.20* instead of parsing the version number. On Mon, Jan 11, 2010 at 4:58 PM, Evan Martin <ev...@google.com> wrote: > On Mon, Jan 11, 2010 at 4:15 PM, Brian Lum <brian...@chromium.org> wrote: >> We need to modify the script by changing the *gold* to *gold*2.20*, >> but it'll be broken once the next version of gold comes out. Do we >> need to check the versioning? Right now, I'm looking into using awk >> or grep to check for the minimum version number. Any suggestions >> would be welcomed. > > I wonder if you could instead do something like > ld --gc-sections /dev/null > and check for it complaining about an unrecognized command line. > > That would correctly succeed for current and future versions. > >> Note that version 2.19 works for Debug. Apparently, I only need 2.20 >> for Release builds. > > Right, that flag is only used in release. >
-- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev