I think either way is fine. It is easy enough to filter frames using
"if (window == top)".

A note in the docs to emphasize the behaviour would help.

On Nov 19, 1:11 pm, Aaron Boodman <a...@google.com> wrote:
> On Thu, Nov 19, 2009 at 12:42 PM, Michael Weber
>
> <michaelhermannwe...@gmail.com> wrote:
> > I don't see any mention of it in the docs, but it makes sense and
> > seems to be what we are seeing.
>
> > I was seeing some unexpected behaviour that is fixed by including a an
> > "if (window == top)" in our content script to ensure it only executes
> > for the root frame.
>
> > In this case, the follow issues I logged are complete bogus and I will
> > update them, and then run back to my corner with my tail between my
> > legs.
>
> > 28148: document HTML sometimes not set correctly in DOM
> > 26513: document url not set correctly in DOM
>
> Yes, content scripts are expected to be run in all frames. I wonder if
> we should change this and make it default to root only. It seems to
> confuse a lot of people.
>
> - a

--

You received this message because you are subscribed to the Google Groups 
"Chromium-extensions" group.
To post to this group, send email to chromium-extensi...@googlegroups.com.
To unsubscribe from this group, send email to 
chromium-extensions+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/chromium-extensions?hl=.


Reply via email to