Aaron, Please notice that ChromePlus does not support this flag at all. I had problems recently with my extension for those who uses this browser (i.e. I added all_frames=true to be ready for the change you're talking about :))
Is there smth we can do about? On Fri, Dec 11, 2009 at 11:45 PM, Aaron Boodman <a...@google.com> wrote: > We really wanted to default it to FALSE. We're going to try it out on > the dev channel and see how much havoc it causes. > > Cross your fingers. > > - a > > On Fri, Dec 11, 2009 at 12:40 PM, Andrey Adaikin > <andrey.adai...@gmail.com> wrote: > > maybe just set the default to TRUE? - nobody will be broken. but having > this > > flag IMO is still a good idea to allow optimization of not injecting > content > > scripts into iframes. > > > > On Fri, Dec 11, 2009 at 6:44 PM, Aaron Boodman <a...@google.com> wrote: > >> > >> +erikkay > >> > >> Sigh. Yes, you are right, the change did not get merged to the beta > >> branch. I wonder if it will break everyone now if I do merge it. > >> > >> - a > >> > >> On Fri, Dec 11, 2009 at 4:13 AM, Andrey <andrey.adai...@gmail.com> > wrote: > >> > Seems like this flag has no effect, so the docs are no valid: > >> > > >> > all_frames boolean Optional. Controls whether the content script > >> > runs > >> > in all frames of the matching page, or only the top frame. Defaults to > >> > false, meaning that only the top frame is matched. > >> > > >> > http://code.google.com/chrome/extensions/content_scripts.html > >> > > >> > Seems like this defaults to TRUE now, not FALSE. > >> > > >> > -- > >> > > >> > You received this message because you are subscribed to the Google > >> > Groups "Chromium-extensions" group. > >> > To post to this group, send email to > >> > chromium-extensi...@googlegroups.com. > >> > To unsubscribe from this group, send email to > >> > chromium-extensions+unsubscr...@googlegroups.com<chromium-extensions%2bunsubscr...@googlegroups.com> > . > >> > For more options, visit this group at > >> > http://groups.google.com/group/chromium-extensions?hl=en. > >> > > >> > > >> > > > > > -- > > > > You received this message because you are subscribed to the Google Groups > > "Chromium-extensions" group. > > To post to this group, send email to > chromium-extensi...@googlegroups.com. > > To unsubscribe from this group, send email to > > chromium-extensions+unsubscr...@googlegroups.com<chromium-extensions%2bunsubscr...@googlegroups.com> > . > > For more options, visit this group at > > http://groups.google.com/group/chromium-extensions?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "Chromium-extensions" group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=en.
