On Tue, Dec 10, 2019 at 04:11:14PM +0100, Christian Ehrhardt wrote: > On Tue, Dec 10, 2019 at 4:06 PM Vincent Blut <vincent.deb...@free.fr> wrote: > > >+hwclock -r --test | grep -q '^ioctl.*RTC_UIE_ON.*Invalid argument$' && > > test_skip "RTC not RTC_UIE_ON capable" > > > > ^^^^^^^^^^^^^^^^ > > Careful here, hwclock is internationalized. > > > > Thanks for the warning, the ioctl and the flag RTC_UIE_ON should be always > the same. > The errno might be changing, but we could just drop that from the check > maybe and be safe?
I'm sorry for changing my mind, but I now think this case should be handled gracefully in chronyd and not avoided in the test. According to the man page, the -s option is supposed to work even with no RTC or broken RTCs. A hang or fatal error with the -s option may break the user's expectation. Do you agree? -- Miroslav Lichvar -- To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe" in the subject. For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the subject. Trouble? Email listmas...@chrony.tuxfamily.org.
