Thanks for that, I've managed to add the patch now. I've updated it to include 
some of your suggestions, while I have some questions about the uid 210, the 
group hadoop, and the use of the bash shell, which I've added to the Jira issue 
(CHUKWA-630), https://issues.apache.org/jira/browse/CHUKWA-630. I realise that 
a prolonged discussion over a two-line patch is a waste of everyone's time, so 
if the specific uid, the bash shell and the group hadoop are considered 
important to have, I will happily add them.

Since it's the start of the weekend here, in NZ, I am adding my non-work email 
if you want to add anything else.

Thanks,

Noel.

-----Original Message-----
From: Eric Yang [mailto:[email protected]] 
Sent: Friday, 20 January 2012 5:22 p.m.
To: [email protected]
Subject: Re: Chukwa RPM does not create user "chukwa"

Hi Noel,

The file attachment action is located in "More Action" then attach file.
Once the file is attached, then use Submit Patch to change the state of the 
jira.
In addition, could you update the patch to suppress user account already exist 
message in case of rpm upgrade?  Something like this:

/usr/sbin/useradd --comment "Chukwa" -u 210 --shell /bin/bash -M -r -g  hadoop 
--home %{_prefix} %{uid} 2> /dev/null || :

Thanks

regards,
Eric

On Thu, Jan 19, 2012 at 7:47 PM, Noel Duffy <[email protected]> wrote:
> I wrote a patch to fix this issue, but the patch submission dialog in JIRA 
> has no place to actually put the patch itself, or at least none that I could 
> see. I am attaching it to this message instead. It's a very simple patch to 
> create the user when the rpm is installed and remove it when the rpm is 
> uninstalled.
>
>
> -----Original Message-----
> From: Eric Yang [mailto:[email protected]]
> Sent: Friday, 20 January 2012 2:03 p.m.
> To: [email protected]
> Subject: Re: Chukwa RPM does not create user "chukwa"
>
> In theory, the headless user should be added by RPM.  At the time the code 
> was developed, the company that we worked for had centralized LDAP.  Hence, 
> it was neglected from RPM installation.  Please file a jira, and we will fix 
> it in the next minor release.  Thanks.
>
> regards,
> Eric
>
> On Thu, Jan 19, 2012 at 3:21 PM, Noel Duffy <[email protected]> 
> wrote:
>> The rpm built by "ant rpm" from Chukwa 0.4.0 attempts to set ownership of 
>> all installed files to user "chukwa", but it does not create this user 
>> account or test whether it exists before performing the installation. Is 
>> this deliberate, or should the rpm add the user first?
>>

Reply via email to