The GitHub Actions job "C++ Linter" on iceberg-cpp.git/error-vector-collection 
has failed.
Run started by GitHub user shangxinli (triggered by shangxinli).

Head commit for run:
f5c45f366e7aeccfa4189ab9ef0a388a21114efb / Xinli Shang <[email protected]>
feat: extract ErrorCollector utility and add AddError overload

Address review comments from wgtmac on PR #358:

1. Add AddError(Error err) overload to accept existing Error objects
   This allows propagating errors from other components without
   deconstructing and reconstructing them.

2. Extract error collection into reusable ErrorCollector utility class
   This eliminates code duplication between PendingUpdateTyped and
   TableMetadataBuilder, and provides a reusable pattern for other
   builders in the codebase.

Changes:
- Add src/iceberg/util/error_collector.h with ErrorCollector class
- Update PendingUpdateTyped to use ErrorCollector internally
- Update TableMetadataBuilder to use ErrorCollector instead of
  std::vector<Error>
- Add test for AddError(Error err) overload
- Add comprehensive documentation with usage examples

All 12 tests pass.

Report URL: https://github.com/apache/iceberg-cpp/actions/runs/19757588436

With regards,
GitHub Actions via GitBox

Reply via email to