Hello Metze, After reviewing the source code, I logged a document bug against [MS-SMB2]. This should be addressed in a future release of the spec. This context is not used or processed by the server but it's important that it's correct. It may be used by load balancers, etc.
Thank you for bringing this to our attention. Regards, Edgar -----Original Message----- From: Bryan Burgin <bbur...@microsoft.com> Sent: Friday, July 26, 2019 12:12 PM To: Stefan Metzmacher <me...@samba.org>; cifs-protocol@lists.samba.org Cc: support <supp...@mail.support.microsoft.com> Subject: [REG:119072621001605] [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID [Dochelp to bcc] [+support] Hi Metze Thank you for your question. We created SR 119072621001605 to track this issue. An engineer will contact you soon. Bryan -----Original Message----- From: Stefan Metzmacher <me...@samba.org> Sent: Friday, July 26, 2019 1:23 AM To: Interoperability Documentation Help <doch...@microsoft.com>; cifs-protocol@lists.samba.org Subject: [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID Hi DocHelp, I just noticed a documentation bug in [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID: NetName (variable): A null-terminated Unicode string containing the server name and specified by the client application. Windows Server 1903 sends the name without null-termination, see the attached capture. Metze == Hi Steve, I just contacted dochelp for this and noticed (from reading the code) that the kernel sends null-termination for the SMB2_NETNAME_NEGOTIATE_CONTEXT_ID value. I think you should fix that and backport it to stable releases, it would be good if all clients would implement it like windows. I implemented it for Samba here: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fsamba-team%2Fsamba%2Fmerge_requests%2F666&data=02%7C01%7Cedgaro%40microsoft.com%7Cfe6cd05e3b3843023c7108d711ec73d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636997579573226427&sdata=8QBaFuwp5NMXpnW8JYSTzorqxSlpFgWcPXX%2BjWkfcZE%3D&reserved=0 metze _______________________________________________ cifs-protocol mailing list cifs-protocol@lists.samba.org https://lists.samba.org/mailman/listinfo/cifs-protocol
