Re: [cifs-protocol] [EXTERNAL] MS-SMB2: Reconnect of second disconnected PH on a file fails if contending open broke H lease - TrackingID#2509250040006209

[Ralph Boehme via cifs-protocol]

Hi Obaid




$ git fetch https://gitlab.com/samba-team/devel/samba.git slow/ph-for-obaid
...
$ git checkout -b slow/ph-for-obaid FETCH_HEAD
...



Let me know if this works.

-Ralph

On 10/13/25 4:19 AM, Obaid Farooqi wrote:

sorry, the below command requires a gitlab account, you can use https instead: I've created a seperate more stable branch "ph-for-obaid" because "ph-testes" is still in flux and may be unstable.

Hi Ralph:
The following command does not work. Here is what I see when executing these 
commands:

abc@DESKTOP-0F1ASDC:~/slow/samba$ git fetch 
"g...@gitlab.com:samba-team/devel/samba.git" 'slow/ph-tests'
g...@gitlab.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
abc@DESKTOP-0F1ASDC:~/slow/samba$

Regards,
Obaid Farooqi
Sr. Escalation Engineer | Microsoft

-----Original Message-----
From: Ralph Boehme <s...@samba.org>
Sent: Monday, October 6, 2025 5:26 AM
To: Obaid Farooqi <oba...@microsoft.com>
Cc: cifs-protocol@lists.samba.org; Microsoft Support <supportm...@microsoft.com>
Subject: Re: [EXTERNAL] MS-SMB2: Reconnect of second disconnected PH on a file 
fails if contending open broke H lease - TrackingID#2509250040006209

Hi Obaid,

https://gitlab.com/samba-team/samba/-/merge_requests/4188

$ git fetch "g...@gitlab.com:samba-team/devel/samba.git" 'slow/ph-tests'
$ git checkout -b 'samba-slow/ph-tests' FETCH_HEAD

The test:

$ bin/smbtorture -d 0 -U 'USER%PASSWORD' //SERVER/SHARE 
smb2.persistent-open.reconnect-contended-two --option=torture:single=yes
--option=torture:subtest=17

Server must be Fileserver-For-General-Use.

Thanks!

On 10/4/25 12:36 AM, Obaid Farooqi wrote:

Hi Ralph:
Is this one of the PH test cases that I can run?
Please let me know the test case # and, also upload a network capture of this 
scenario to the following link:

https://support.microsoft.com/files?workspace=eyJhbGciOiJSUzI1NiIsImtp

ZCI6IjJBNzk1QUQxMDNDQTM4OEZENEQzREQxQTZERkU4QTE2RDkyMkNDQkMiLCJ0eXAiOi
JKV1QifQ.eyJ3c2lkIjoiNzUzYTIwMzktY2Q3OS00ZWZjLTg0YmYtZTIyYzIzZDQyNzE2I
iwic3IiOiIyNTA5MjUwMDQwMDA2MjA5Iiwic3YiOiJ2MSIsInJzIjoiRXh0ZXJuYWwiLCJ
3dGlkIjoiNjRhMzY4NTMtNjdmYS00NWQ3LTg5NjItMjc0ZGZiZGViYWRhIiwiYXBwaWQiO
iI0ZTc2ODkxZC04NDUwLTRlNWUtYmUzOC1lYTNiZDZlZjIxZTUiLCJuYmYiOjE3NTk1MzA
4OTYsImV4cCI6MTc2NzMwNjg5NSwiaWF0IjoxNzU5NTMwODk2LCJpc3MiOiJodHRwczovL
2FwaS5kdG1uZWJ1bGEubWljcm9zb2Z0LmNvbSIsImF1ZCI6Imh0dHA6Ly9zbWMifQ.J0gP
8LIQEThWlwlLlFsh6XIgtWNkc4vnRFxWjaVFXmmWzFbkUXuT647F4sRMgnYP6CWx27weuZ
9Vo7LdUqS1lupAXlJBeHlzq5sEsvA8Xl1H_gsLrGMJROpJl1aE9GUBzjrypWjB6wI0WZc9
9JuiQ3eEW9-aVlauQOziwvzm_5DYd8SQ9Cje91qnBhR2Zoy7wwK3laKh_-WtCHe1xkWCuX
V7ywV2tSwdvnPrCJLiQObWZxailC1xgaRQ9gvSL1_PAqCfT98bOkuCPdX6VlJ5Va7DpBPd
24dZCdUlJxjOs12pwgcTP1Ibz_G0DrxMqr7-VUI62XhfktAQIzABLgYnwg&wid=753a203
9-cd79-4efc-84bf-e22c23d42716

Regards,
Obaid Farooqi
Sr. Escalation Engineer | Microsoft

-----Original Message-----
From: Michael Bowen <mike.bo...@microsoft.com>
Sent: Thursday, September 25, 2025 10:07 AM
To: Ralph Boehme <s...@samba.org>
Cc: cifs-protocol@lists.samba.org; Microsoft Support
<supportm...@microsoft.com>
Subject: RE: [EXTERNAL] MS-SMB2: Reconnect of second disconnected PH
on a file fails if contending open broke H lease -
TrackingID#2509250040006209

Hi Ralph,

Thanks for your question. I've created case number 2509250040006209to track 
this issue. Please leave the number in the subject line and use reply all your 
correspondence. One of our engineers will contact you soon.

Best regards,
Michael Bowen
Sr. Escalation Engineer - Microsoft® Corporation


-----Original Message-----
From: Ralph Boehme <s...@samba.org>
Sent: Thursday, September 25, 2025 7:46 AM
To: Interoperability Documentation Help <doch...@microsoft.com>
Cc: cifs-protocol@lists.samba.org
Subject: [EXTERNAL] MS-SMB2: Reconnect of second disconnected PH on a
file fails if contending open broke H lease

Hi dochelp!

I'm sorry, but I just ran into another issue I fail to understand...
:)

Scenario:

Reconnect of second disconnected PH on a file fails if contending open caused a 
break of the H lease.

Server: Windows 2025, Fileserver for General Use
Client: smbtorture

CG := Create Guid
LK := Lease Key

1. Client 1: open file with PH, lease=RWH, LK=X, CG=Y 2. Client 1:
another open on the same file with PH, lease=RWH, LK=X, CG=Z (same LK
as in 1) 3. Disconnect 4. Client 2: content disconnected handles with
another open that triggers a break and is suspended 5. Client 1
reconnects 6. Client 1 reconnects first PH 7. Server sends lease break
for LK=X to NONE to client 1 8. Client 1 acks lease break 9. Client 1
attempts to reconnect second PH but this fails with
STATUS_FILE_NOT_AVAILABLE

In my understanding 9 should not fail and in my implementation of PH in Samba 
it succeeds.

Am I missing anything in the docs why 9 should fail?

In my testing with various lease levels and different sharemodes and access 
masks of the contending open, the pattern seems to be that the second reconnect 
alway fails if the contending open triggered a H lease break.

Thanks!
-slow

OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
cifs-protocol mailing list
cifs-protocol@lists.samba.org
https://lists.samba.org/mailman/listinfo/cifs-protocol