This patch has been checked into CinGG source. In addition, I added the "const" to the red, green, and blue colors in filegif.C because that is better defined. Thank you Andrew and Rob.
Reminder to see changes: https://git.cinelerra-gg.org/?p=goodguy/cinelerra.git;a=summary to clone: git clone https://git.cinelerra-gg.org/goodguy/cinelerra.git On Wed, Dec 3, 2025 at 2:15 AM Andrew Randrianasulu <[email protected]> wrote: > Hopefully attached patch should fix compilation? > > ср, 3 дек. 2025 г., 12:07 Andrew Randrianasulu <[email protected]>: > >> >> >> ср, 3 дек. 2025 г., 11:34 Rob Prowel <[email protected]>: >> >>> On 11/26/25 4:25 PM, Phyllis Smith wrote: >>> > Rob/Andrew - >>> > Tested my usual builds with Andrew's patch and then rendered a Gif >>> > Sequence with no problems. Not sure if that includes all necessary >>> > tests concerning Gif but hope so. I would have liked to test by >>> > building without thirdparty but I do not have sufficient disk space to >>> > install all of the Operating System libraries to use instead of the >>> > thirdparty ones. It has been checked into GIT with the following >>> commit: >>> > >>> > commit 0bb5444770e3db55113e4c012d0a1074e30f4475 >>> > >>> > Thanks to Rob for pointing out this deficiency and Andrew for >>> addressing. >>> >>> >>> two things: >>> >>> 1) I thought the patch was going to do a an autoconf test to determine >>> the existence of the quant function but it does not. I can force the >>> issue with CXXFLAGS=-DHAVE_GIFLIB_QUANTIZE but we can defer that for the >>> moment. >>> >>> 2) your filegif.C line-238: #endif is on the wrong line. It partially >>> truncates the function and causes a compilation failure. It should be >>> moved to line 251. >>> >> >> Ah, thanks. Will fix and send fix to mail list. >> >> >> >>> So there is no confusion, this is my make-config under Deb-13 >>> ------------------------------------------------------------------------- >>> >>> #! /bin/bash >>> >>> export CFLAGS="-ggdb -O0 -DHAVE_GIFLIB_QUANTIZE" >>> export CXXFLAGS=$CFLAGS >>> export CUDA_PATH=/usr >>> >>> aclocal >>> libtoolize >>> automake --add-missing >>> autoconf >>> >> >> >> there should be ./autogen.sh for this ... >> >> >> >>> ./configure \ >>> --prefix=/sharebin/cingg2511 \ >>> --with-cuda \ >>> --with-nv \ >>> --with-gl \ >>> --with-xv \ >>> --with-jobs=12 \ >>> --with-alsa \ >>> --enable-audiofile \ >>> --with-thirdparty=no \ >>> >>> >>> >>>
_______________________________________________ Cin mailing list -- [email protected] To unsubscribe send an email to [email protected]
