Andraz,

I made the changes you suggested... The UI looks much cleaner like this !
Thanks for the tips.

It would be a good idea to commit it in soon, because it fixes some
pretty bad behavior I introduced in the previous patch :-(
The adaptive averaging, temporal swap and spatial swap were all messed up.

Now everything should be in a good shape,
   Jerome  


Andraz Tori wrote:

>Ok, i've checked the plugin. I am really glad that finally deinterlacing
>is getting solved in proper way in cinelerra. Though algorithm leaves
>something to be desired - when run on my test footage... :)
>
>Anyway, if you have started a redesing of the deinterlacer GUI, maybe
>you should go to the end and actually remove the widgets when they are
>meaningless - this would avoid some confusion... You can checkout how
>this is done in the Gradient plugin ..
>
>also using the checkbox for top/bottom field.. i believe two radio
>buttons would be much better solution
>
>Otherwise as i said, any developement in this field can only be a good
>thing... 
>
>I am commiting your changes now... 
>
>bye
>andraz
>
>
>On pon, 2006-02-06 at 23:59 -0500, Jerome Cornet wrote:
>  
>
>>   OK,
>>
>>I worked hard over the weekend, and here's what I came up with:
>>an additional plugin that does a "smart" Bob&Weave.
>>
>>The algorithm is fairly simple:
>>Keep each dominant line the same (Top or bottom, depending on the
>>configuration)
>>For the other line, check each pixel:
>>       if it is very different from the previous frame, interpolate from
>>the line above and below (bob)
>>       if it's similar, keep it (weave)
>>The "similarity" calculation is a fudgy calculation based on the Pot
>>control on the configuration window
>>
>>In summary, for the static parts of the image you get the full
>>resolution, and for the moving parts you get an interpolated, half
>>vertical resolution block.
>>
>>It's pretty fast, not the best but really better than what's currently
>>in Cinelerra.
>>
>>Also, the plugin interface was getting really crowded with all those
>>additions, so I reworked it completely.
>>I'd appreciate some feedback from whoever's interested (Andraz ? ;-) )
>>
>>The patch to the current CVS is here:
>>http://jcornet.free.fr/linux/download/cinelerra/deinter.patch.gz
>>The full plugin code is there:
>>http://jcornet.free.fr/linux/download/cinelerra/deinterlace.tgz
>>
>>Let me know what you think,
>>   Jerome
>>    
>>
>
>  
>

Attachment: deinterlace.patch.gz
Description: application/gzip

Reply via email to