On Feb 17, 2007, at 21:07:58, Johannes Sixt wrote:
Thanks, but:
- There was talk recently that compilation fails on amd_64
unless --enable-mmx=no. Your patch sets it to 'yes' if --enable-mmx
was not
set. I had to fix this particular problem. Has something changed? See
https://init.linpro.no/pipermail/skolelinux.no/cinelerra/2007-
January/009702.html
http://repo.or.cz/w/cinelerra_cv.git?
a=commitdiff;h=f7ca8d92e1c0cb0ef90cbc17506d388dd5cb0622
http://repo.or.cz/w/cinelerra_cv.git?
a=commitdiff;h=052cb77e7d96c19ae260f696baa9d40c6e2313cc
i was using libavcodec from ubuntu, not the one coming with cinelerra
- Is libx264_pic a commonly used name or specific to ubuntu?
its also present in debian, not sure about others.
- I'd like to move the x86_64 case above the powerpc case. Ok?
sure
- Adding all those optimization options, -funroll-loops -minline-
all-stringops
etc. to the default compile line is a big NO-NO. It may be
convenient for
you, but it is not good practice in general. Is there any harm done
if I
remove them?
i guess you can remove them too
- You define an AM_CONDITIONAL named CPU_x86_64 that is not used
anywhere. Ok
to remove it?
its not used right now so it might be ok to remove it.
- The assignment libx264_pic=yes must read libx264=yes. I'll fix that.
ok
j
_______________________________________________
Cinelerra mailing list
Cinelerra@skolelinux.no
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
