2007/11/13, Johannes Sixt <[EMAIL PROTECTED]>: > Thanks. > > On Tuesday 13 November 2007 17:49, KH KH wrote: > > http://www.pipapo.org/gitweb?p=cinelerra/mob;a=commit;h=88e99c04955c5a7e052 > >c78c38fed61c30f1572dc This will fix undefined-non-weak-symbol rpmlint > > errors: > > cinelerra.x86_64: W: undefined-non-weak-symbol > > /usr/lib64/libguicast.so.1.0.0 png_create_read_struct > > ... > > cinelerra.x86_64: W: undefined-non-weak-symbol > > /usr/lib64/libguicast.so.1.0.0 cmodel_components > > ... > > Please be more specific in the commit message. e.g. the above error message > description is the least it should contain. Have you analyzed why this > happens, and why it is necessary to add more libraries to the link line? > These symbols are used in guicast since ages, and at no times were there any > problems... > Ok I will be more verbose on the commit message next time...
Actually this fix isn't related to a build time error or a runtime crash as symbols are found in the result "package" but "the startup time of the application will be a bit slower as the dynamic linker has to resolve the missing deps at launch time" I thought the patch was trivial, so i haven't explained it more... I don't think this is related to other fixes I have in Fedora package as (toolame and mpeg2enc are built shared). I've also removed unused-direct-shlib-dependencies: W: unused-direct-shlib-dependency /usr/lib64/libmpeg3hv-1.5.0.so.1.0.0 /lib64/libdl.so.2 W: unused-direct-shlib-dependency /usr/lib64/libquicktimehv-1.6.0.so.1.0.0 /usr/lib64/libavutil.so.49 W: unused-direct-shlib-dependency /usr/lib64/libquicktimehv-1.6.0.so.1.0.0 /usr/lib64/libpostproc.so.51 W: unused-direct-shlib-dependency /usr/lib64/libquicktimehv-1.6.0.so.1.0.0 /usr/lib64/libvorbisfile.so.3 W: unused-direct-shlib-dependency /usr/lib64/libquicktimehv-1.6.0.so.1.0.0 /usr/lib64/libtheora.so.0 W: unused-direct-shlib-dependency /usr/lib64/libquicktimehv-1.6.0.so.1.0.0 /lib64/libdl.so.2 W: unused-direct-shlib-dependency /usr/lib64/libguicast.so.1.0.0 /usr/lib64/libGLU.so.1 W: unused-direct-shlib-dependency /usr/lib64/libguicast.so.1.0.0 /lib64/libdl.so.2 But this was done patching libtool between configure and make from the "spec" file with: # clean unused-direct-shlib-dependencies sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool > > BTW, you don't need to and should not put your name in the commit message - it > is recorded in its own field anyway. OK > -- Hannes > Nicolas (kwizart) _______________________________________________ Cinelerra mailing list Cinelerra@skolelinux.no https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
