Hi. On Wed, Sep 28, 2011 at 4:24 PM, Raffaella Traniello <raffaella.tranie...@g-raffa.eu> wrote: > Ciao! > > On 09/23/2011 05:35 PM, Einar Rünkaru wrote: >> >> Anyone who sends patches! Please start a new thread whith subject >> "[PATCH] Name of the patch". In the mail describe what and why the >> patch is good. > > I added that to the Guideline at http://cinelerra.org/main_repo.php > ("Mail notification") > > >> On Thu, Sep 22, 2011 at 9:15 PM, Paul Taggart<ptagg...@cinci.rr.com> >> wrote: >>> >>> Attached is an updated ffmpeg patch that supports both the >>> included ffmpeg version and external ffmpeg. This patch also fixes >>> issues with fileac3.C. This patch appears to work on both 2.1.5 and >>> 2.2 versions of Cinelerra. >> >> Paul, version 2.2 of Cinelerra is not out yet, so you can't say that >> it works with 2.2., but you have to mention with what versions of >> ffmpeg your patch works. At first glance the patch seems good. >> Missing: Name of the patch and description. > > Paul, it would be nice to include this patch to CinCV2.2. > Please, help CinCV by sending a good name for the patch and a detailed > description (see the Guidelines for more info). > > Thank you! >
Some explanation why Paul's ffmpeg patch can't be accepted now. Patch itself is fine, but Cinelerra (quicktime) assumes, that after every packet sent to video decoder returnd decoded frame. If decoder does not return frame, Cinelerra flags error and outputs a black frame. If frame has bigger resolution (HD) the probability to get error raises. Quick test showed that video decoded without problems with internal ffmpeg gave errors with later ffmpegs. Conclusion: parts of Cinellerra surrounding ffmpeg need careful rewriting and testing. Einar _______________________________________________ Cinelerra mailing list Cinelerra@skolelinux.no https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
