On Thu, Sep 23, 2004 at 07:36:01PM -0400, Marc E. Fiuczynski wrote:
> > if (!cfqq) {
> > + spin_unlock_irq(cfqd->queue->queue_lock);
> > cfqq = mempool_alloc(cfq_mpool, GFP_NOIO);
> > + spin_lock_irq(cfqd->queue->queue_lock);
>
> hmm, any reason to get the lock here and not
> later on, when you initialized the cfqq?
>
> Looks like he is releasing and getting the lock on cfqd (note the 'd' at the
> end) and not cfqq.
yep, saw that, but no need to reacquire it _before_
the cfqq initialization is complete ...
best,
Herbert
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
