On Sat, 2006-10-14 at 13:10 -0700, Joel Becker wrote:
> On Sat, Oct 14, 2006 at 12:43:51PM -0700, Andrew Morton wrote:
> > On Sat, 14 Oct 2006 01:01:07 -0700
> > Greg KH <[EMAIL PROTECTED]> wrote:
> > > Argh!!!!
> > >
> > > Are you going to honestly tell me you have a single attribute in sysfs
> > > that is larger than PAGE_SIZE?
> >
> > He does not. It's a matter of reusing existing facilities rather than
> > impementing similar things in multiple places. The equivalent patch in
> > configfs removed a decent amount of code:
>
> Issues of PAGE_SIZE and attribute size aside, the patch posted
> was incorrect. While they used seq_file, they implemented it in a
I do not think it is incorrect. It provides a simplest interface to
configfs's clients.
> completely inefficent fashion, filling the entire buffer in one ->show()
> call rather than letting multiple read(2) calls iterate their list.
So, are you suggesting that we should provide a generic seq_operations
interface to configfs's clients ?
>
> Joel
>
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- [EMAIL PROTECTED] | .......you may get it.
----------------------------------------------------------------------
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
