Pau, Wop! This is a lot... But thanks for your effort in pointing them all.
I was trying to do "co" before making my new patch. Here I found a problem: 149-159-132-38:CLAM yushen$ svn co https://iua-share.upf.edu/svn/clam/trunk clam svn: REPORT request failed on '/svn/clam/!svn/vcc/default' svn: Working copy path 'CLAM/plugins/temporal_oboeSynthesizer' does not exist in repository It seemed that in repository there is no temporal_oboeSynthesizer but a RealtimeSMSSynthesizer dir under plugins. This could be some chaos created by my own patch. I am sorry about that. ----------- I think I fixed most of the following problems locally. > 4. Why these nested dirs? Fix it > loopMaker/loopMaker/ The reason why I have a nested dir is to keep a separate SConstruct file for this dir-based loopMaker. The user will go to loopMaker to compile it while the code is located in oopMaker/loopMaker. Is that okay? I apologize for the chaos and your extra effort caused by my patch. Best regards, Han, Yushen On Mon, Aug 4, 2008 at 7:21 AM, Pau Arumí <[EMAIL PROTECTED]> wrote: > > Wow, looked at the patch and still see many problems. > > 1. No new files should go into: > deprecated/ > > 2. Please do not add backups in a patch: > Sconstruct.old > synthesis.bak > LoopingSDIFFileReader.c__ > ContinuousExcitationSynthesizer.c__ > loopMaker/loopMaker/LoopPointExtractor.c__ > SMSIo.old > README.old > > > 3. *Never, ever* add scons generated files in a patch: > .sconsign.dblite > loopMaker/options.cache > options.cache > > 4. Why these nested dirs? Fix it > loopMaker/loopMaker/ > > 5. .pos files are deprecated. Positions are now in the main > .clamnetwork file: > > synth_with_osc.clamnetwork.pos and others > > 6. What is this? Probably to remove. > TestScores/linebreakMac.tx > SConstruct.con > loopMaker.scons > > 7. there are system changes that do not belong to this patch > CLAM/src/Data/BasicProcessing/Spectrum.cxx > CLAM/src/Processing/Plugins/RunTimeLibraryLoader.cxx > CLAM/src/Processing/Plugins/RunTimeProcessingLibraryLoader.cxx > > The patch should be done "svn diff CLAM/plugins > my.patch" > Did you needed to change Spectrum?? Glups > > > Please take your time to produce clean patches --this is a community > open-source project, not a personal repository. Some amount of chaos is > allowed in the plugins/ dir. But not *that* amount. > Also take into account that the less time maintainers spend on trivial > patches issues, the happier they are :-) > > P > > > On dl, 2008-08-04 at 06:39 -0400, Han, Yushen wrote: >> Hi, Pau >> >> Here you go: this patch will be applied to the dir >> "temporal_oboeSynthesizer". >> In spite of its name, it is actually a "merged" version. >> >> I know this is not exactly what you intended to have, but I think it >> is easier for me to test this merged version (dealing with instruments >> of different nature) since it will be our final delivery. >> >> >> Best regards, >> Han, Yushen >> >> On Mon, Aug 4, 2008 at 6:02 AM, Pau Arumí <[EMAIL PROTECTED]> wrote: >> > On dl, 2008-08-04 at 05:39 -0400, Han, Yushen wrote: >> >> Hi, Pau >> >> >> >> Here is it. >> > >> > Wrong. This patch creates a new dir plugins/RealtimeSMSSynthesizer >> > You should be patching the existing ones. I precisely created >> > "temporal_oboeSynth" so that you move all your code there. Please check >> > that (old) mail. >> > >> > Answering previous mail: >> >> Hi, Pau >> >> >> >> Thanks for your clear instruction. >> >> >> >> I have only one question: is "CLAM/plugins/temporal_oboeSynthesizer" a >> >> legitimate name >> >> that has been reserved in CLAM system? >> > >> > It is a temporal dir to hold changes not merged with Greg's synth. We >> > can have all the experimental dirs we want in plugins/, no problem :-) >> > >> > P >> > >> > >> >> I just made the patch for my working (testbed) dir - it is still >> >> called "RealtimeSMSSynthesizer". >> >> But I can rename it and make it again if you want to put it under >> >> "temporal_oboeSynthesizer". >> > >> > >> > >> >> Han, Yushen >> >> >> >> On Mon, Aug 4, 2008 at 5:38 AM, Han, Yushen <[EMAIL PROTECTED]> wrote: >> >> > Hi, Pau >> >> > >> >> > Thanks for your clear instruction. >> >> > >> >> > I have only one question: is "CLAM/plugins/temporal_oboeSynthesizer" a >> >> > legitimate name >> >> > that has been reserved in CLAM system? >> >> > >> >> > I just made the patch for my working (testbed) dir - it is still >> >> > called "RealtimeSMSSynthesizer". >> >> > But I can rename it and make it again if you want to put it under >> >> > "temporal_oboeSynthesizer". >> >> > >> >> > Best regards, >> >> > Han, Yushen >> >> > >> >> > On Mon, Aug 4, 2008 at 4:43 AM, Pau Arumí <[EMAIL PROTECTED]> wrote: >> >> >> On dg, 2008-08-03 at 19:58 -0400, Han, Yushen wrote: >> >> >>> Hi, >> >> >>> >> >> >>> Here is the merged plugin - RealtimeSMSSynthesizer >> >> >>> >> >> >>> I tried to create a patch by the way described in devel >> >> >>> "Change dir to the root of your svn tree (the directory containing >> >> >>> CLAM/ and NetworkEditor/, etc.) and do >> >> >>> $ svn diff > good-description.patch" >> >> >>> >> >> >>> However, it worked only for my modification on CLAM system files but >> >> >>> not for this new plugin. >> >> >>> So I send this 960KB patch in a .tar file that contains all the code >> >> >>> plus test scores (under TestScores). >> >> >>> Is there a better way to send a patch of a new plugin? >> >> >> >> >> >> Yes, sending a .tar with 147(!) files is definitely not the way :-) >> >> >> (see >> >> >> attached the list of files contained in the .tar file) >> >> >> >> >> >> The idea is propose specific (and preferable small) changes to the >> >> >> repository by means of patches. >> >> >> >> >> >> You should be working in either >> >> >> CLAM/plugins/continuousExcitationSynthesizer >> >> >> or CLAM/plugins/temporal_oboeSynthesizer >> >> >> but not a third directory! >> >> >> The first is the "final" dir and the second is a testbed temporal dir. >> >> >> >> >> >> If you want to rename dirs, send proposals to the list. >> >> >> >> >> >> About adding new files to a patch: >> >> >> >> >> >> 1. do svn add newfile (being in a svn directory) >> >> >> 2. prepare the patch normally. The new file will be included >> >> >> 3. some commiter apply the patch >> >> >> 4. you update the repo: "svn up". BUT BE AWARE of new added files. They >> >> >> will conflict when doing the svn up. So *before* doing svn up, do "svn >> >> >> rm newfile". >> >> >> 5. if 4. fails, apply brute force: move the directory with the new file >> >> >> (say, temporal_oboeSynthesizer) out of the svn tree. And do svn up. >> >> >> >> >> >> So let's try to produce proper patches. >> >> >> Thanks, >> >> >> >> >> >> P >> >> >> >> >> >> >> >> >> >> >> >> >> >> > >> > >> > > > _______________________________________________ Clam-devel mailing list Clam-devel@llistes.projectes.lafarga.org https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel
