[cp-patches] SimpleTimeZone.getOffset() fix

[Mark Wielaard]

Hi,

Thanks to Audrius for walking me through the code and Mauve test I think
we found the cause of some of the remaining mauve failures with
SimpleTimeZone. We store the endTime internally as local time (so
including the dst offset), but getOffset() takes the millis as offset
into the day in standard time. This doesn't matter for the start time
(since that is given already in standard time), but does matter for the
end time.

2005-02-20  Mark Wielaard  <[EMAIL PROTECTED]>

        * java/util/SimpleTimeZone.java (getOffset): Calculate beforeEnd by
        taking dstSavings into account.

This does not introduce any mauve regressions and fixes the following
Muave failures:

-FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 4)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 4)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 8)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 8)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 12)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 12)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 16)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 16)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 20)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 20)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 10)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 11)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 12)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 10)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 11)
+PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 12)
-FAIL: gnu.testlet.java.util.SimpleTimeZone.getOffset: (int, int, int, int, 
int, int) (number 4)
+PASS: gnu.testlet.java.util.SimpleTimeZone.getOffset: (int, int, int, int, 
int, int) (number 4)

Comments?

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part

_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches