On Thu, 2005-07-07 at 16:13 -0400, Aaron Luchko wrote:
> I've found a couple issues with the style formatter included
> in .settings/org.eclipse.jdt.core.prefs
>
> I'm still investigating how to handle a few anomalies (it looks like
> there might be some bugs in some of the eclipse formatting code) but
> I've been able to fix one setting where a "throws" clause wouldn't
> automatically be put on a new line and would be indented by two instead
> of four when it was
>
> The guidelines I'm going by are here,
>
> "Implements and extends on separate lines, throws too. Indent extends,
> implements, throws. Apply deep indentation for method arguments."
> http://www.gnu.org/software/classpath/docs/hacking.html#SEC6
>
> As well eclipse automatically added a setting for enum_constants which
> shouldn't affect anything.
>
> Aaron
>
> ChangeLog
>
>
> 2005-07-05 Aaron Luchko <[EMAIL PROTECTED]>
> * .settings/org.eclipse.jdt.core.prefs: Fixed indent of 'throws'
> clause for eclipse formatter
Oops, generated the patch at the wrong level and gave the wrong date on
the ChangeLog entry :)
It's also worthwhile to note that in general these changes should be
propagated to scripts/eclipse-gnu.xml, the standalone settings for the
formatter.
Unfortunately the eclipse functionality to do so seems to be broken at
the moment so I'll have to update eclipse-gnu.xml at a later date.
2005-07-07 Aaron Luchko <[EMAIL PROTECTED]>
* .settings/org.eclipse.jdt.core.prefs: Fixed indent of 'throws'
clause for eclipse formatter
Index: .settings/org.eclipse.jdt.core.prefs
===================================================================
RCS file: /cvsroot/classpath/classpath/.settings/org.eclipse.jdt.core.prefs,v
retrieving revision 1.2
diff -u -p -r1.2 org.eclipse.jdt.core.prefs
--- .settings/org.eclipse.jdt.core.prefs 1 May 2005 22:05:52 -0000 1.2
+++ .settings/org.eclipse.jdt.core.prefs 7 Jul 2005 20:55:41 -0000
@@ -1,4 +1,4 @@
-#Mon Apr 25 22:37:20 MDT 2005
+#Thu Jul 07 16:02:40 EDT 2005
eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
@@ -60,6 +60,7 @@ org.eclipse.jdt.core.formatter.alignment
org.eclipse.jdt.core.formatter.alignment_for_binary_expression=18
org.eclipse.jdt.core.formatter.alignment_for_compact_if=16
org.eclipse.jdt.core.formatter.alignment_for_conditional_expression=82
+org.eclipse.jdt.core.formatter.alignment_for_enum_constants=0
org.eclipse.jdt.core.formatter.alignment_for_expressions_in_array_initializer=18
org.eclipse.jdt.core.formatter.alignment_for_multiple_fields=16
org.eclipse.jdt.core.formatter.alignment_for_parameters_in_constructor_declaration=18
@@ -68,8 +69,8 @@ org.eclipse.jdt.core.formatter.alignment
org.eclipse.jdt.core.formatter.alignment_for_superclass_in_type_declaration=16
org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_enum_declaration=16
org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_type_declaration=16
-org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration=16
-org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_method_declaration=16
+org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration=36
+org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_method_declaration=36
org.eclipse.jdt.core.formatter.blank_lines_after_imports=1
org.eclipse.jdt.core.formatter.blank_lines_after_package=1
org.eclipse.jdt.core.formatter.blank_lines_before_field=1
@@ -290,3 +291,4 @@ org.eclipse.jdt.core.formatter.number_of
org.eclipse.jdt.core.formatter.put_empty_statement_on_new_line=true
org.eclipse.jdt.core.formatter.tabulation.char=space
org.eclipse.jdt.core.formatter.tabulation.size=2
+org.eclipse.jdt.core.formatter.use_tabs_only_for_leading_indentations=false
_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
