[cp-patches] FYI: little bugs in DSAKeyPairGenerator

[Casey Marshall]

Hi,

This fixes a copy-and-paste bug I introduced in my previous change to  
this class, and fixes the return values for 'getDefaults' for 768 and  
1024 bit keys.

Committed.

2005-08-14  Casey Marshall  <[EMAIL PROTECTED]>

    * gnu/java/security/provider/DSAKeyPairGenerator.java
    (initialize): set 'keysize' to 'modlen.'
    (getDefaults): return 'true' for keysizes '768' and '1024.'

Index: gnu/java/security/provider/DSAKeyPairGenerator.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/gnu/java/security/provider/DSAKeyPairGenerator.java,v
retrieving revision 1.6
diff -u -B -b -r1.6 DSAKeyPairGenerator.java
--- gnu/java/security/provider/DSAKeyPairGenerator.java 9 Aug 2005 06:13:54 
-0000       1.6
+++ gnu/java/security/provider/DSAKeyPairGenerator.java 15 Aug 2005 03:14:21 
-0000
@@ -114,7 +114,7 @@
        if( ((modlen % 64) != 0) || (modlen < 512) || (modlen > 1024) )
                 throw new InvalidParameterException();
 
-        this.keysize = keysize;
+        this.keysize = modlen;
         this.random = random;
         if (this.random == null)
         {
@@ -181,10 +181,12 @@
                p = new 
BigInteger("e9e642599d355f37c97ffd3567120b8e25c9cd43e927b3a9670fbec5d890141922d2c3b3ad2480093799869d1e846aab49fab0ad26d2ce6a22219d470bce7d777d4a21fbe9c270b57f607002f3cef8393694cf45ee3688c11a8c56ab127a3daf",
 16);
                q = new BigInteger("9cdbd84c9f1ac2f38d0f80f42ab952e7338bf511", 
16);
                g = new 
BigInteger("30470ad5a005fb14ce2d9dcd87e38bc7d1b1c5facbaecbe95f190aa7a31d23c4dbbcbe06174544401a5b2c020965d8c2bd2171d3668445771f74ba084d2029d83c1c158547f3a9f1a2715be23d51ae4d3e5a1f6a7064f316933a346d3f529252",
 16);
+                return true;
        } else if( keysize == 1024) {
                p = new 
BigInteger("fd7f53811d75122952df4a9c2eece4e7f611b7523cef4400c31e3f80b6512669455d402251fb593d8d58fabfc5f5ba30f6cb9b556cd7813b801d346ff26660b76b9950a5a49f9fe8047b1022c24fbba9d7feb7c61bf83b57e7c6a8a6150f04fb83f6d3c51ec3023554135a169132f675f3ae2b61d72aeff22203199dd14801c7",
 16);
                q = new BigInteger("9760508f15230bccb292b982a2eb840bf0581cf5", 
16);
                g = new 
BigInteger("f7e1a085d69b3ddecbbcab5c36b857b97994afbbfa3aea82f9574c0b3d0782675159578ebad4594fe67107108180b449167123e84c281613b7cf09328cc8a6e13c167a8b547c8d28e0a3ae1e2bb3a675916ea37f0bfa213562f1fb627a01243bcca4f1bea8519089a883dfe15ae59f06928b665e807b552564014c3bfecf492a",
 16);
+                return true;
        }
        return false;
 }
_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches