On Fri, 2005-09-16 at 08:50 -0600, Tom Tromey wrote:
> >>>>> "Anthony" == Anthony Green <[EMAIL PROTECTED]> writes:
> 
> Anthony> Ok, how about this then....
> 
> This patch is going to be nit-picked to death :-)
> 
> Anthony> +    // This shouldn't really happen.
> Anthony> +        InternalError ie = new InternalError();
> Anthony> +    ie.initCause(e);
> Anthony> +    throw ie;
> 
> How about a message in the error?  With that change it is fine.
> Thanks.

We discussed on IRC.  I committed this patch without a message, but
collapsed into one line like so:

  // This shouldn't ever happen.
  throw (InternalError) new InternalError().initCause(e);

After all this discussion I kind of hope this exception _is_ thrown some
day :-)

AG




_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to