Hi,

> Am Dienstag, den 20.09.2005, 12:02 +0000 schrieb David Gilbert:
>> Roman Kennke wrote:
>>
>> >I added some defaults to the MetalLookAndFeel (text field borders).
>> >
>> >-      "TextField.border", MetalBorders.getTextFieldBorder(),
>> >+      "TextField.border",
>> >+      new BorderUIResource(MetalBorders.getTextFieldBorder()),
>> >
>> >
>> >
>> Hi Roman,
>>
>> When I saw this I wondered if the getTextFieldBorder() method should
>> return a border that already implements UIResource.  I added some Mauve
>> tests that confirm that it does, so I think this change should be
>> reverted and getTextFieldBorder() fixed instead.
>
> Yeah ok, I'll do this and check it in. What about the getTextBorder()
> method? I assume it'll be the same here.

Ok, I have fixed this.

2005-09-20  Roman Kennke  <[EMAIL PROTECTED]>

        * javax/swing/plaf/metal/MetalBorders.java
        (getTextFieldBorder): This method must return an BorderUIResource
        instance. Fixed.

/Roman
Index: javax/swing/plaf/metal/MetalBorders.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/metal/MetalBorders.java,v
retrieving revision 1.17
diff -u -r1.17 MetalBorders.java
--- javax/swing/plaf/metal/MetalBorders.java	20 Sep 2005 09:29:41 -0000	1.17
+++ javax/swing/plaf/metal/MetalBorders.java	20 Sep 2005 12:42:06 -0000
@@ -1156,7 +1156,8 @@
       {
         Border inner = getMarginBorder();
         Border outer = new TextFieldBorder();
-        textFieldBorder = BorderFactory.createCompoundBorder(outer, inner);
+        textFieldBorder =
+          new BorderUIResource.CompoundBorderUIResource(outer, inner);
       }
     return textFieldBorder;
   }
_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to