my latest patch to JFileChooser made some JFileChooser methods call into
its UI. Unfortunatly, these methods are implemented to call back into
the JFileChooser, which is obviously wrong. Fixed.
2005-10-12 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicFileChooserUI.java
(getFileView): Don't call back into the JFileChooser, avoids
a StackOverflow.
(getApproveButtonText): Likewise.
/Roman
Index: javax/swing/plaf/basic/BasicFileChooserUI.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java,v
retrieving revision 1.13
diff -u -r1.13 BasicFileChooserUI.java
--- javax/swing/plaf/basic/BasicFileChooserUI.java 4 Oct 2005 21:02:10 -0000 1.13
+++ javax/swing/plaf/basic/BasicFileChooserUI.java 12 Oct 2005 19:42:01 -0000
@@ -1836,8 +1836,6 @@
*/
public FileView getFileView(JFileChooser fc)
{
- if (fc.getFileView() != null)
- return fc.getFileView();
return fv;
}
@@ -1902,9 +1900,7 @@
*/
public String getApproveButtonText(JFileChooser fc)
{
- if (fc.getApproveButtonText() != null)
- return fc.getApproveButtonText();
- else if (fc.getDialogType() == JFileChooser.SAVE_DIALOG)
+ if (fc.getDialogType() == JFileChooser.SAVE_DIALOG)
return saveButtonText;
else
return openButtonText;
_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
