Hi, I would say that is ok. However would you mind documenting this change in NEWS and look whether README or INSTALL have references to that configure switch and update it accordingly?
cu Robert Andreas Tobler wrote: > Hello > > To avoid confusion in kaffe and elsewhere it would make sense to rename > the --with-qtdir to --with-qt4dir in the OS-X Qt config section. > Kaffe for example uses --with-qtdir for Qt versions 2/3/embedded. > > Ok? > > Andreas > > 2005-10-24 Andreas Tobler <[EMAIL PROTECTED]> > > * configure.ac: Rename --with-qtdir to --with-qt4dir to make clear > which Qt version is meant. > > > > Index: configure.ac > =================================================================== > RCS file: /cvsroot/classpath/classpath/configure.ac,v > retrieving revision 1.113 > diff -u -r1.113 configure.ac > --- configure.ac 23 Oct 2005 16:59:07 -0000 1.113 > +++ configure.ac 24 Oct 2005 21:54:19 -0000 > @@ -370,14 +370,14 @@ > AC_MSG_NOTICE([Looking for QT_CFLAGS and QT_LIBS without pkg-config]) > case "$host_os" in > darwin*) > - AC_ARG_WITH([qtdir], > - [AS_HELP_STRING([--with-qtdir=DIR], > + AC_ARG_WITH([qt4dir], > + [AS_HELP_STRING([--with-qt4dir=DIR], > [Qt4 installation directory used for OS-X. > For other systems use pkg-config.])], > [QT4DIR=$withval] > ) > if test x"$QT4DIR" = x ; then > - AC_MSG_ERROR([*** No path for Qt4 --with-qtdir option given]) > + AC_MSG_ERROR([*** No path for Qt4 --with-qt4dir option given]) > fi > AC_MSG_RESULT([QT4DIR... $QT4DIR]) > AC_CHECK_PROG(MOC, [moc], [$QT4DIR/bin/moc], [], $QT4DIR/bin) > > > _______________________________________________ > Classpath-patches mailing list > Classpath-patches@gnu.org > http://lists.gnu.org/mailman/listinfo/classpath-patches > > _______________________________________________ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches
