Hi Nicolas, On Fri, 2005-12-02 at 17:52 +0100, Nicolas Geoffray wrote: > Last RFC, and I'm commiting this in > > 2005-12-02 Nicolas Geoffray <[EMAIL PROTECTED]> > > * java/lang/instrument: New directory. > * java/lang/instrument/ClassDefinition.java: > New file. > * java/lang/instrument/ClassFileTransformer.java: > New file. > * java/lang/instrument/IllegalClassFormatException.java: > New file. > * java/lang/instrument/Instrumentation.java: > New file. > * java/lang/instrument/UnmodifiableClassException.java: > New file. > * vm/reference/java/lang/InstrumentationImpl.java: > New file. > * vm/reference/java/lang/VMInstrumentationImpl.java: > New file.
Looks very nice! Thanks. One change request: - Please put only VMInstrumentationImpl into vm/reference/java/lang and put InstrumentationImpl (which is shared and for which we don't expect people to change it per VM) into java/lang/ directly. Two nitpicks: - We check for null in InstrumentationImpl.getObjectSize() so the VMInstrumentationImpl.getObjectSize() documentation should say that. - There should be a space after if, while and synchronized according to our coding style guides. When you commit this can you please send a little message explaining the new instrumentation addition and how runtime hackers are supposed to provide support for it to the main classpath mailinglist? That way we hopefully get more feedback and make sure runtime hackers aren't completely surprised when this pops up in the next (generics) release. Thanks, Mark _______________________________________________ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches
