Hi Roman, On Mon, 2006-01-23 at 15:21 +0100, Roman Kennke wrote: > > This broke File locking. In particular the mauve test > > gnu.testlet.java.nio.channels.FileChannel.lock and the eclipse osgi > > locking. How did you test this patch and on what platforms? > > > > I have a hard time seeing how this patch is supposed to work. You > > replace the calls with new target layer functionality, but that > > functionality seems to depend on having things like > > TARGET_NATIVE_FILE_LOCKMODE_READ, which depend on things like > > HAVE_F_RDLCK being defined, but I cannot find where you exactly do this. > > I tested this with the JamaicaVM. Sorry, I didn't run a full test with > JamVM/Classpath or similar. The HAVE_F_RDLCK thing very much sounds like > an autoconf test. I'll check this with Torsten and come back to it.
Thanks. Please do test against one of the free runtimes that the other hackers also use in the future when making such invasive changes, or ask someone else to test it for you before committing. If investigating this takes more than a day could you revert the patch temporarily so we don't have a broken tree for too long? Cheers, Mark
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
