hello Mark, On Monday 06 February 2006 09:53, Mark Wielaard wrote: > Hi Raif, > > On Sun, 2006-02-05 at 09:12 +1100, Raif S. Naffah wrote: > > > > if (!(key instanceof DSSPublicKey)) > > > > throw new InvalidParameterException("key"); > > > > > > Officially there is a space after each operator, so also for ! to > > > make it more clearly stand out... > > > > yes we can do that: force a white space after a unary operator, but > > then we get: > > > > boolean condition1 = false; > > boolean condition2 = true; > > // ... > > if (condition1 & ! condition2) > > { > > // do something > > } > > > > rather than > > if (condition1 & !condition2) > > > > if this is what we want then i'll update the style specs file > > accordingly. > > I think that is what we want yes...
ok. > > ... > > or a.2: > > > > public class Main > > extends KeyGenerator > > implements java.io.Serializable > > According to our coding style guide a.2 is the correct one. > Although mostly people do a.1 and only fall back on a.2 when the line > gets > 78 chars. (And they would do an import java.io.Serializable > and implements Serializable). > > > b/ Javadoc style; which is more acceptable: > > > > b1: > > > > * @param input the byte array to unmarshall into a valid DSS > > * [EMAIL PROTECTED] PublicKey} instance. > I would say b1. Although we don't have a very precise coding style > here. cool. i'll post shortly a patch for the .xml style file in the project. thanks + cheers; rsn
pgpwJV2wZYapI.pgp
Description: PGP signature