I remove one more duplication of the PropertyChangeSupport thingy in
java.awt.Container. From the specs it is not immediately clear to me why
addPropertyChangeListener is overridden in java.awt.Container. So I let
it call super for now.

2006-02-06  Roman Kennke  <[EMAIL PROTECTED]>

        * java/awt/Container.java
        (changeSupport): Removed duplicate (from Component) field.
        (addPropertyChangeListener): Call super.

/Roman
Index: java/awt/Container.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/Container.java,v
retrieving revision 1.78
diff -u -r1.78 Container.java
--- java/awt/Container.java	4 Feb 2006 11:08:43 -0000	1.78
+++ java/awt/Container.java	6 Feb 2006 16:05:57 -0000
@@ -102,7 +102,6 @@
 
   /* Anything else is non-serializable, and should be declared "transient". */
   transient ContainerListener containerListener;
-  transient PropertyChangeSupport changeSupport; 
 
   /** The focus traversal policy that determines how focus is
       transferred between this Container and its children. */
@@ -1541,28 +1540,18 @@
     if (orientation == null)
       throw new NullPointerException ();
   }
-  
+
   public void addPropertyChangeListener (PropertyChangeListener listener)
   {
-    if (listener == null)
-      return;
-
-    if (changeSupport == null)
-      changeSupport = new PropertyChangeSupport (this);
-
-    changeSupport.addPropertyChangeListener (listener);
+    // TODO: Why is this overridden?
+    super.addPropertyChangeListener(listener);
   }
-  
-  public void addPropertyChangeListener (String name,
+
+  public void addPropertyChangeListener (String propertyName,
                                          PropertyChangeListener listener)
   {
-    if (listener == null)
-      return;
-    
-    if (changeSupport == null)
-      changeSupport = new PropertyChangeSupport (this);
-
-    changeSupport.addPropertyChangeListener (name, listener);
+    // TODO: Why is this overridden?
+    super.addPropertyChangeListener(propertyName, listener);
   }
 
 

Reply via email to