On Fri, 2006-02-10 at 15:10 +0000, Roman Kennke wrote:
> I added the missing ElementBuffer.clone() method.
> 
> 2006-02-10  Roman Kennke  <[EMAIL PROTECTED]>
> 
>         * javax/swing/text/DefaultStyledDocument.java
>         (ElementBuffer.clone): New method.

I don't understand ... I implemented this method on November 8, 2005 and
committed the ChangeLog and sent an email to this list ... did I forget
to commit the actual change or something?

Oh I see now...it was in the wrong place, not in the inner ElementBuffer
class.  Wups.

Roman, comparing the one I wrote to the one you wrote, I think your
second argument to replace is wrong ... no Elements are being removed
here since the just-created BranchElement has no children.  I think it
should be branchClone.replace(0, 0, cloneChildren).  

If you agree, can you fix this?  And could you remove the one I wrote at
the same time?

--Tony


Reply via email to