Michael Koch wrote:

On Thu, Feb 16, 2006 at 01:49:47PM +0100, Audrius Meskauskas wrote:
Now the bottom "close" button disappears in the Swing Demo after any attempt to expand a tree node or resize the table column.

Listen, it may sound nasty, but PLEASE USE SWING ACTIVITY BOARD AND MAUVE TESTS TO CHECK THE EFFECTS of the "performance fixes", "optimizations" and "removing unnecessary code". I understand that it may be some subtle regressions, but that is happening looks more that you just do not care, leaving your code to for others to debug.

Work in the team do put some restrictions.

Come on. Cool down.

Roman is taking a lot of care. He does a great job. As the other Swing
hackers do too. Sometimes things break. That is what happens in
development. When you cant fix it imidiately report it to Roman or the one
who broke and not randomly revert patches.


Cheers,
Michael
Hey, this is great news! We now have enough free-Swing hackers to have (little) fights over CVS check-ins! I think Audrius has made a good point, that it is sometimes wise to run the activity board to check that nothing obvious has broken before committing certain types of patches.

At the same time, I agree that Roman is doing a great job, and always fixes these things quickly when informed about them.

So lets just head for the middle ground: more testing, more tolerance and...more beer at FOSDEM 2006!

Regards,

Dave

Reply via email to