Mark Wielaard wrote:
On Thu, 2006-02-16 at 14:21 -0800, Keith Seitz wrote:
Another pretty simple one. VirtualMachineCommandSet.executeIDsizes was
really jumping through hoops because JdwpID.size was abstract. Fooey.
This patch makes size() a static method and includes all the necessary
changes in other files.
I've changed this to using a constant, as you suggest. I don't know
right now why I chose to use a method originally. With any luck, it
won't matter any more. :-)
Small style nitpicks:
+//import gnu.classpath.jdwp.VMField;
+import gnu.classpath.jdwp.VMFrame;
+//import gnu.classpath.jdwp.VMMethod;
Please add "FIXME, not yet implemented" or something similar to such
uncommented code.
I've just whacked these commented out imports altogether. The FIXME is
already mentioned in executeIDsizes.
+ os.writeInt(VMFrame.size ()); // frameId
[...]
+ public static int size ()
Both method invocation and method declaration don't have a space between
the method name and the opening bracket. This is different from the C
coding style guide (and not always followed in all our code...)
Ah, so no spaces at all between method names and parentheses in
Classpath? Is there a standard list of options to GNU indent through
which I can run the code to get an acceptable output which I can commit
en masse?
Keith
