This patch (committed) replaces 'new Boolean(true)' with 'Boolean.TRUE' to save
creating a new instance:
2006-03-06 David Gilbert <[EMAIL PROTECTED]>
* javax/swing/plaf/metal/MetalLookAndFeel.java
(initComponentDefaults): Use Boolean.TRUE for
'CheckBoxMenuItem.borderPainted'.
This was pointed out by running FindBugs (http://findbugs.sourceforge.net/).
Regards,
Dave
Index: javax/swing/plaf/metal/MetalLookAndFeel.java
===================================================================
RCS file:
/sources/classpath/classpath/javax/swing/plaf/metal/MetalLookAndFeel.java,v
retrieving revision 1.78
diff -u -r1.78 MetalLookAndFeel.java
--- javax/swing/plaf/metal/MetalLookAndFeel.java 15 Feb 2006 16:20:13
-0000 1.78
+++ javax/swing/plaf/metal/MetalLookAndFeel.java 6 Mar 2006 21:05:39
-0000
@@ -1,5 +1,5 @@
/* MetalLookAndFeel.java
- Copyright (C) 2002, 2005 Free Software Foundation, Inc.
+ Copyright (C) 2002, 2005, 2006, Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -899,7 +899,7 @@
"CheckBoxMenuItem.acceleratorForeground", getAcceleratorForeground(),
"CheckBoxMenuItem.acceleratorSelectionForeground",
getAcceleratorSelectedForeground(),
"CheckBoxMenuItem.background", getMenuBackground(),
- "CheckBoxMenuItem.borderPainted", new Boolean(true),
+ "CheckBoxMenuItem.borderPainted", Boolean.TRUE,
"CheckBoxMenuItem.commandSound", "sounds/MenuItemCommand.wav",
"CheckBoxMenuItem.checkIcon", MetalIconFactory.getCheckBoxMenuItemIcon(),
"CheckBoxMenuItem.disabledForeground", getMenuDisabledForeground(),