Hello list,
I commited the attached patch to fix some methods and a class variable to be final. Cheers, Michael 2006-03-08 Michael Koch <[EMAIL PROTECTED]> * java/net/Proxy.java (NO_PROXY): Made final. (equals): Likewise. (hashCode): Likewise.
Index: java/net/Proxy.java =================================================================== RCS file: /sources/classpath/classpath/java/net/Attic/Proxy.java,v retrieving revision 1.1.2.1 diff -u -r1.1.2.1 Proxy.java --- java/net/Proxy.java 7 Mar 2006 13:12:33 -0000 1.1.2.1 +++ java/net/Proxy.java 8 Mar 2006 12:01:18 -0000 @@ -51,7 +51,7 @@ */ public enum Type { DIRECT, HTTP, SOCKS }; - public static Proxy NO_PROXY = new Proxy(Type.DIRECT, null); + public static final Proxy NO_PROXY = new Proxy(Type.DIRECT, null); private Type type; private SocketAddress address; @@ -96,7 +96,7 @@ * @return <code>true</code> if both objects or equals, * <code>false</code> otherwise. */ - public boolean equals(Object obj) + public final boolean equals(Object obj) { if (! (obj instanceof Proxy)) return false; @@ -112,7 +112,7 @@ * * @return the hashcode */ - public int hashCode() + public final int hashCode() { return type.hashCode() ^ address.hashCode(); }