Roman Kennke wrote:
> my collegue Fridjof has been playing around with data flow 
> analysis and spotted some interesting points where we could improve
> robustness a little. For the most part this creates local variables
> for fields in some places (see ChangeLog entry below) and operates
> on these instead of the fields themselves. This way we make 100%
> sure that the fields isn't nullified in between. While it may appear
> clear to us that this never happens, with the described approach
> it can easily be proven(!) that this can't happen (for example,
> using DFA tools).

IMO the SystemProperties changes are wrong. If there is a bug somewhere
that causes a property to by queried *during* the static initializer of
SystemProperties, we *want* the system to crash with a
NullPointerException, not to silently fail and cause problems down the
road.

Regards,
Jeroen

Reply via email to