Re: [cp-patches] FYI: new Swing demo

[Mark Wielaard]

Hi Roman,

On Wed, 2006-03-15 at 16:46 +0000, Roman Kennke wrote:
> I redesigned the Swing demo a little. What I did:
> 
> 1. throw away the 'XXXWorld' tabbed pane in the center.
> 2. 'Outsourced' the XXXWorld stuff in separate demos just like the
> other demos. This is TreeDemo, ListDemo and TabbedPaneDemo. The
> ButtonWorld and DesktopWorld are no longer there. IMO the ButtonWorld
> was quite useless and confusing. Eventually we would write a BorderDemo
> to replace it. The DesktopWorld is replaced by point#3
> 3. Added a desktop. This desktop shows a GNU Classpath badge in the
> middle.
> 4. Made the subdemos appear as internal frames inside the new desktop.
> 
> IMO this makes the Swing activity board more clear. Eventually we should
> move all those buttons in the toolbar with icons instead of labels. But
> that is not that important.

It looks really nice. The buttons on the bottom do eat up a lot of
screen though. We really should just remove them imho. You can always
just use the examples menu.

> Note that I added a PNG file (the GNU Classpath badge). I hope it shows
> up for everybody. Otherwise the Makefiles must be tweaked a little so
> that png files are included in the examples.zip. I must say that I
> always start the demo without the examples.zip so I have no problems
> there.

It is a problem when using it with the examples.zip, because that now
doesn't contain the badge icon. The easiest way to make it work in all
cases is to just put it in the icons directory and use it from there
with getResource().

2006-03-16  Mark Wielaard  <[EMAIL PROTECTED]>

    * examples/gnu/classpath/examples/swing/badge.png: Removed.
    * examples/gnu/classpath/examples/icons/badge.png: Added.
    * examples/gnu/classpath/examples/swing/DemoDesktop.java: Use badge
    from icon directory.

I committed this to make it all work out of the box even with an
installed examples.zip.

I am seeing three issues:
- I cannot switch to the GNU look and feel anymore
- After switching themes an internal frame isn't draggable anymore.
- Minimizing/Maximizing an internal frame doesn't remove/repaint the old
  state.
But besides that the Demo is now really impressive. Great work!

Cheers,

Mark

diff -u -r1.1 DemoDesktop.java
--- examples/gnu/classpath/examples/swing/DemoDesktop.java      15 Mar 2006 
16:41:02 -0000      1.1
+++ examples/gnu/classpath/examples/swing/DemoDesktop.java      16 Mar 2006 
10:13:05 -0000
@@ -64,7 +64,8 @@
   DemoDesktop()
   {
     super();
-    image = new ImageIcon(getClass().getResource("badge.png"));
+    String badge = "/gnu/classpath/examples/icons/badge.png";
+    image = new ImageIcon(getClass().getResource(badge));
   }

   /**

signature.asc
Description: This is a digitally signed message part