Hi Gary, On Tue, 2006-04-04 at 11:14 +0100, Gary Benson wrote: > A lot of big projects (gcc, X, Python) do the following: > > #ifndef MAXPATHLEN > #define MAXPATHLEN 4096 > #endif > > I'm inclined to do the same (if it works for them...) but where > should I put it? target_generic_file.h?
If it is good enough for them it should be good enough for us also. As soon as we get systems where a path can actually exceed 4K we can see how these projects solve that issue and hopefully do something similar. Do note that with that define you will end up using 3 * 4K for each toCanonicalForm() operation. target_generic_file.h seems like a fine place for now. I have CCed Guilhem to make sure he knows that define is necessary in the future for his native-layer work. > > Could you also add a little note the the NEWS file under > > Runtime/Platform interface changes? > > This ok? > > * The method gnu.java.io.PlatformHelper.toCanonicalForm() has been > replaced with a JNI implementation of VMFile.toCanonicalForm() for > GNU/Posix systems. Looks fine. Thanks, Mark
signature.asc
Description: This is a digitally signed message part
