>>>>> "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes:
Ian> 1) >>> by a negative amount - this was in the code to achieve a
Ian> rotate. To make the code readable the patch adds a rotate
Ian> method which is called instead. As the rotate method is private
Ian> it should be an excellent candidate for inlining and not impact
Ian> on performance.
This one is fine by me. However I think some of the other changes
are problematic :-(
Ian> 2) final fields that could have been static weren't - so I made them
Ian> static :-)
Usually this is done for API compatibility and represents a historical
accident. At least, that's true for public API. We can't change
this.
If jikes warnings for this kind of thing are annoying, about all you
can do is turn them off.
Ian> 4) the inner class EditorContainer of DefaultTreeCellEditor had a
Ian> method whose name matched that of being constructor but it wasn't a
Ian> constructor - the comments in the code suggested this method
Ian> shouldn't be there, so I removed it
Required for API compatibility.
Ian> Index: external/sax/org/xml/sax/helpers/ParserAdapter.java
As a rule we don't touch external/. Instead try upstream... though
I've had no results so far with this.
Ian> + private static int rotate(int x, int y) {
Ian> + return (x << y) | (x >>> -y);
Ian> + }
Coding style... open brace goes on its own line.
Tom
