Re: [cp-patches] RFC: DatatypeFactory implementation resolution mechanism

[Chris Burdess]

Tom Tromey wrote:

Chris> Please review the following patch for conformance to the API
Chris> specification of DatatypeFactory.newInstance

Looking pretty good.

Chris> +        // 2. jaxp.properties property

Chris> +        File javaHomeLib = new File(javaHome, "lib");

We usually use gnu.classpath.home.url here.

Chris> + File javaHome = new File(System.getProperty ("java.home"));

The specification actually says to use $JAVA_HOME.

Chris> +        // 3. services

Chris> +          .getResourceAsStream("/META-INF/services/" +
Chris> +                               DATATYPEFACTORY_PROPERTY);

We usually use gnu.classpath.ServiceFactory for this kind of thing.

Chris> + InputStream in = DatatypeFactory.class.getClassLoader()

I incorporated this suggestion and committed.

2006-04-26  Chris Burdess  <[EMAIL PROTECTED]>

        Fixes PR 27290
        * javax/xml/datatype/DatatypeFactory.java: Use complete
          implementation resolution mechanism.

--
犬 Chris Burdess
  "They that can give up essential liberty to obtain a little safety
  deserve neither liberty nor safety." - Benjamin Franklin

patch
Description: Binary data

PGP.sig
Description: This is a digitally signed message part