Lillian Angel wrote:
On Mon, 2006-05-08 at 14:17 -0600, Tom Tromey wrote:
"Lillian" == Lillian Angel <[EMAIL PROTECTED]> writes:
Lillian> A fixed a small bug in the last patch I committed.
Lillian> Unfortunately, this is the best way to load all the jars listed in
Lillian> INDEX.LIST.
This patch has a problem and a missing feature.
The problem is that it doesn't actually parse the index file format.
It is merely looking for lines that end in '.jar' -- but a package
name can also validly end that way.
I agree. Thanks for pointing this out. I have created a helper file in
gnu/java/net to do the parsing of INDEX.LIST
2006-05-08 Lillian Angel <[EMAIL PROTECTED]>
* gnu/java/net/IndexListParser.java: New class.
* java/net/URLClassLoader.java
(JarURLLoader): Fixed code to use new class.
The missing feature is that one of the major points of using
index.list is to speed up applications by letting jars be lazily
downloaded. This isn't implemented at all. I don't think this is a
requirement before checking the patch in, but I do think that PR 27444
should be left open until this feature is implemented.
Yes, I spoke to fitzsim about this earlier. It is inefficent at the
moment and will need to be fixed later. The bug has been reopened.
This looks fine. Thanks,
Tom
