Tom Tromey wrote:
"Tom" == Thomas Fitzsimmons <[EMAIL PROTECTED]> writes:

Tom> I committed the attached patch to add an appletviewer to GNU Classpath.

Awesome!

Tom> * resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties:
Tom> New file.
Tom> * resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties:
Tom> New file.

These have C-style /* */ comments at the top -- that's wrong for a
property file.  Instead it should be '#' comments.

Fixed by attached patch.


Tom>          * tools/appletviewer.c: New file.

Nothing compiles this.

Yes, this file is only intended to be compiled by VMs that bundle GNU Classpath and support the JNI invocation API. When we do the next GNU Classpath -> libgcj import, we'll need to patch the libgcj build to create an "appletviewer" binary.

I'd like to see all tools have a similar wrapper binary, since in my experience with java-gcj-compat, wrapper binaries are more robust than wrapper scripts.

Tom

2006-05-09  Thomas Fitzsimmons  <[EMAIL PROTECTED]>

        * resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties:
        Use hash-style comments.
        * 
resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties:
        Likewise.

Index: resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties
===================================================================
RCS file: /sources/classpath/classpath/resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties,v
retrieving revision 1.1
diff -u -r1.1 MessagesBundle.properties
--- resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties	8 May 2006 20:36:45 -0000	1.1
+++ resource/gnu/classpath/tools/appletviewer/MessagesBundle.properties	9 May 2006 14:03:33 -0000
@@ -1,39 +1,39 @@
-/* MessagesBundle.properties -- English language messages
-   Copyright (C) 2004, 2006  Free Software Foundation, Inc.
-
-This file is part of GNU Classpath.
-
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
-
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-02110-1301 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
+# MessagesBundle.properties -- English language messages
+# Copyright (C) 2004, 2006  Free Software Foundation, Inc.
+#
+# This file is part of GNU Classpath.
+#
+# GNU Classpath is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# GNU Classpath is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with GNU Classpath; see the file COPYING.  If not, write to the
+# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 USA.
+#
+# Linking this library statically or dynamically with other modules is
+# making a combined work based on this library.  Thus, the terms and
+# conditions of the GNU General Public License cover the whole
+# combination.
+#
+# As a special exception, the copyright holders of this library give you
+# permission to link this library with independent modules to produce an
+# executable, regardless of the license terms of these independent
+# modules, and to copy and distribute the resulting executable under
+# terms of your choice, provided that you also meet, for each linked
+# independent module, the terms and conditions of the license of that
+# module.  An independent module is a module which is not derived from
+# or based on this library.  If you modify this library, you may extend
+# this exception to your version of the library, but you are not
+# obligated to do so.  If you do not wish to do so, delete this
+# exception statement from your version.
 
 gcjwebplugin.code_description= Code attribute
 gcjwebplugin.codebase_description= Codebase attribute
Index: resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties
===================================================================
RCS file: /sources/classpath/classpath/resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties,v
retrieving revision 1.1
diff -u -r1.1 MessagesBundle_de.properties
--- resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties	8 May 2006 20:36:45 -0000	1.1
+++ resource/gnu/classpath/tools/appletviewer/MessagesBundle_de.properties	9 May 2006 14:03:33 -0000
@@ -1,41 +1,41 @@
-/* MessagesBundle_de.properties -- German language messages
-   Copyright (C) 2004, 2006  Free Software Foundation, Inc.
+# MessagesBundle_de.properties -- German language messages
+# Copyright (C) 2004, 2006  Free Software Foundation, Inc.
+#
+# This file is part of GNU Classpath.
+#
+# GNU Classpath is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# GNU Classpath is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with GNU Classpath; see the file COPYING.  If not, write to the
+# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 USA.
+#
+# Linking this library statically or dynamically with other modules is
+# making a combined work based on this library.  Thus, the terms and
+# conditions of the GNU General Public License cover the whole
+# combination.
+#
+# As a special exception, the copyright holders of this library give you
+# permission to link this library with independent modules to produce an
+# executable, regardless of the license terms of these independent
+# modules, and to copy and distribute the resulting executable under
+# terms of your choice, provided that you also meet, for each linked
+# independent module, the terms and conditions of the license of that
+# module.  An independent module is a module which is not derived from
+# or based on this library.  If you modify this library, you may extend
+# this exception to your version of the library, but you are not
+# obligated to do so.  If you do not wish to do so, delete this
+# exception statement from your version.
 
-This file is part of GNU Classpath.
-
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
-
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-02110-1301 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
-
-/* FIXME: rewrite this */
+# FIXME: rewrite this:
 gcjwebplugin.help.0=Syntax: appletviewer [Optionen] <Dateiname>.class | <Dateiname>.html... | URL...
 gcjwebplugin.help.1=Optionen:
 gcjwebplugin.help.2=  --help                                Diese Hilfe anzeigen and beenden

Reply via email to