Tom Tromey wrote:
> I'm posting this for comments.
>
> In libgcj we have a divergence in URLClassLoader, because we have
> other ways to load classes. In particular we can extract classes
> from shared libraries via 'gcjlib' URLs, and URLClassLoader knows
> about this.
>
> I'd like to re-merge here so that we have one less divergence to carry
> around.
>
> This patch allows this by moving the URLLoader class, and friends, to
> gnu.java.net.loader. Then it changes URLClassLoader to look for
> other loaders via reflection. This will let us add new URLLoader
> subclasses in the libgcj tree and have things work properly.
I like it.
> + catch (ClassNotFoundException ignore)
> + {
> + // Fall through.
> + }
> + catch (NoSuchMethodException ignore)
> + {
> + // Fall through.
> + }
> + catch (InstantiationException ignore)
> + {
> + // Fall through.
> + }
> + catch (InvocationTargetException ignore)
> + {
> + // Fall through.
> + }
> + catch (IllegalAccessException ignore)
> + {
> + // Fall through.
> + }
Do we really want to swallow all these exception? Obviously
ClassNotFoundException, but others should only result from programming
errors or classes that incorrectly follow the naming convention, right?
Regards,
Jeroen
