Hi Robert, > Cool that this is now fixed.
Well, it's not complete yet. This is why I still didn't close the PR. > > However, there is one (minor IMO) problem left. As it is now, the > > positionMarks array is never cleaned up, that means that marks are kept > > there, even if their corresponding GapContentPosition is GC'ed. This > > might get slightly inefficient in large documents with lots of edits. > > However, the fact that marks and GapContentPositions are reused when > > possible alleviates for that inefficiency a little. So the array can > > never grow larger than the maximum document length. We might want to > > consider to either track GapContentPositions beeing GC'ed (using a > > ReferenceQueue) or perform some manual cleanup regularily. I added a > > FIXME for that. > Could you open a PR for that. FIXMEs tend to be forgotten ... I left the PR open for that reason. I have some stuff on my HD, that improves the situation, but still isn't perfect. Cheers, Roman -- “Improvement makes straight roads, but the crooked roads, without Improvement, are roads of Genius.” - William Blake
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
