Sven de Marothy wrote:
On Sun, 2006-05-28 at 20:07 -0400, Thomas Fitzsimmons wrote:
Can you add to the GdkGraphics2D NEWS entry to mention the new XRENDER
dependency? Please commit,
Well, we shouldn't really have an Xrender dependency. There's a check
there in the code for a reason. So we'll need some #ifdefs in the code
to sort this out.
The decision value for the ifdef has to be taken from somewhere...
You can not use functions which might not be available. You have to
check somehow if they are available.
The patch I sent is incomplete in this regard. I think we have to define
a HAVE_XRENDER or something similar. And then you could use this to make
the code dependent. Otherwise you'll always end up with undefined
symbols on systems which do not have this function.
My problem is maybe only package dependent, but if you have a system
lacking the libXrender.x you'll also fail....
So I think the check should not hurt, it only brings some benefit.
I'll extend the check and write a news entry if this is ok. Otherwise
we're going to limit cp to systems which silently fullfil the
requirements. Means Linux :(
Andreas
