hello all,
the attached patch --already committed-- fixes a bug in the above.
the TestOfConfigurationParser Mauve test (in
gnu.testlet.javax.security.auth.login) should now pass.
2006-06-11 Raif S. Naffah <[EMAIL PROTECTED]>
* gnu/javax/security/auth/login/ConfigFileParser.java
(validateClassName):
Check that every component of 'cn' starts with a valid Java identifier
char.
cheers;
rsn
Index: ConfigFileParser.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/javax/security/auth/login/ConfigFileParser.java,v
retrieving revision 1.2
diff -u -r1.2 ConfigFileParser.java
--- ConfigFileParser.java 9 Jun 2006 16:41:14 -0000 1.2
+++ ConfigFileParser.java 10 Jun 2006 23:59:59 -0000
@@ -268,8 +268,9 @@
for (int i = 0; i < tokens.length; i++)
{
String t = tokens[i];
- if (Character.isJavaIdentifierStart(cn.toCharArray()[0]))
- abort("");
+ if (! Character.isJavaIdentifierStart(t.toCharArray()[0]))
+ abort("Class name [" + cn
+ + "] contains an invalid sub-package identifier: " + t);
// we dont check the rest of the characters for isJavaIdentifierPart()
// because that's what the tokenizer does.
