Re: [cp-patches] FYI: Generate name the same way as Sun

[Robert Schuster]

Hi Tania

>>+    if (type == 0)
>>+      name = "Default Cursor";
>>+    else if (type == 1)
>>+      name = "Crosshair Cursor";
>>+    else if (type == 2)
>>+      name = "Text Cursor";
>>+    else if (type == 3)
>>+      name = "Wait Cursor";
>>+    else if (type == 4)
>>+      name = "Southwest Resize Cursor";
>>+    else if (type == 5)
>>+      name = "Southeast Resize Cursor";
>>+    else if (type == 6)
>>+      name = "Northwest Resize Cursor";
>>+    else if (type == 7)
>>+      name = "Northeast Resize Cursor";
>>+    else if (type == 8)
>>+      name = "North Resize Cursor";
>>+    else if (type == 9)
>>+      name = "South Resize Cursor";
>>+    else if (type == 10)
>>+      name = "West Resize Cursor";
>>+    else if (type == 11)
>>+      name = "East Resize Cursor";
>>+    else if (type == 12)
>>+      name = "Hand Cursor";
>>+    else if (type == 13)
>>+      name = "Move Cursor";
>>+      
>>+    // FIXME: lookup?
There are names for these constants and I see a pattern how you could implement
this much more efficiently:

String[] NAMES = { "Default Cursor", "Crosshair Cursor", ... };

if (type >= 0 && type < NAMES.length
        name = NAMES[type];
else
    // dont know. Try on the RI :)


cya
Robert

signature.asc
Description: OpenPGP digital signature