On Jul 10, 2006, at 7:12 PM, Vivek Lakshmanan wrote:
Hi,This is an update to http://developer.classpath.org/pipermail/ classpath-patches/2006-June/002635.html. Replaces SystemProperties.getProperty with GetPropertyAction in an AccessController.doPrivileged block. Since this idea has been approved already, I will commit this tomorrow unless there are any objections in the mean time.
Looks fine, just lines like these
- String ls = SystemProperties.getProperty("line.separator");
+ String ls = (String) AccessController.doPrivileged(new
GetPropertyAction(
+
"line.separator"));
should be on one line (Eclipse did this, I bet).When there are are long lines without "good" places to break, I tend to break before an opening parenthesis, or before a period. Something like this:
String ls = (String) AccessController.doPrivileged
(new GetPropertyAction("line.separator"));
Although, I don't know what others prefer for situations like this.
PGP.sig
Description: This is a digitally signed message part
