[cp-patches] FYI: Genericize java.lang.management fully

[Andrew John Hughes]

This completes Tromey's patch to the management methods,
by actually using typed lists in the method.  It also allowed
it to spot a bug, which I will also fix on HEAD...

Changelog:

2006-07-10  Andrew John Hughes  <[EMAIL PROTECTED]>

        * java/lang/management/ManagementFactory.java:
        (getMemoryPoolMXBeans): Genericized fully.
        (getMemoryManagerMXBeans): Likewise.
        (getGarbageCollectorMXBeans): Likewise.

-- 
Andrew :-)

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

Index: java/lang/management/ManagementFactory.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/java/lang/management/ManagementFactory.java,v
retrieving revision 1.1.2.6
diff -u -3 -p -u -r1.1.2.6 ManagementFactory.java
--- java/lang/management/ManagementFactory.java 10 Jul 2006 19:41:14 -0000      
1.1.2.6
+++ java/lang/management/ManagementFactory.java 11 Jul 2006 20:01:17 -0000
@@ -204,7 +204,8 @@ public class ManagementFactory
    */
   public static List<MemoryPoolMXBean> getMemoryPoolMXBeans()
   {
-    List poolBeans = new ArrayList();
+    List<MemoryPoolMXBean> poolBeans =
+      new ArrayList<MemoryPoolMXBean>();
     String[] names = VMManagementFactory.getMemoryPoolNames();
     for (int a = 0; a < names.length; ++a)
       poolBeans.add(new MemoryPoolMXBeanImpl(names[a]));
@@ -220,11 +221,12 @@ public class ManagementFactory
    */
   public static List<MemoryManagerMXBean> getMemoryManagerMXBeans()
   {
-    List managerBeans = new ArrayList();
+    List<MemoryManagerMXBean> managerBeans =
+      new ArrayList<MemoryManagerMXBean>();
     String[] names = VMManagementFactory.getMemoryManagerNames();
     for (int a = 0; a < names.length; ++a)
       managerBeans.add(new MemoryManagerMXBeanImpl(names[a]));
-    managerBeans.add(getGarbageCollectorMXBeans());
+    managerBeans.addAll(getGarbageCollectorMXBeans());
     return managerBeans;
   }
 
@@ -237,7 +239,8 @@ public class ManagementFactory
    */
   public static List<GarbageCollectorMXBean> getGarbageCollectorMXBeans()
   {
-    List gcBeans = new ArrayList();
+    List<GarbageCollectorMXBean> gcBeans =
+      new ArrayList<GarbageCollectorMXBean>();
     String[] names = VMManagementFactory.getGarbageCollectorNames();
     for (int a = 0; a < names.length; ++a)
       gcBeans.add(new GarbageCollectorMXBeanImpl(names[a]));

signature.asc
Description: Digital signature