[cp-patches] FIY: Clone fix for gnu.java.security.OID

[Mario Torre]

Il giorno ven, 14/07/2006 alle 00.15 +0200, Mark Wielaard ha scritto:

> That is not a very good comment. What about: 'Implemented using
> super.clone()' to describe what you did?
> 
> Cheers,
> 
> Mark

For some reason I have not the email from David Daney.
But anyway, thanks for the reply, I have committed with this Changelog
message (hope is better):

2006-07-14  Mario Torre  <[EMAIL PROTECTED]>

        * gnu/java/security/OID.java (OID): Private Constructor removed as
        it is not needed anymore.
        (clone): Fixed. Now uses super.clone instead of the private
        constructor as per specification of clone method.
        (serialVersionUID): added new field to allow serialization.


Mario

-- 
Lima Software, SO.PR.IND. s.r.l.
http://www.limasoftware.net/
pgp key: http://subkeys.pgp.net/

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/

===================================================================
RCS file: /sources/classpath/classpath/gnu/java/security/OID.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- classpath/gnu/java/security/OID.java	2006/05/20 03:25:09	1.7
+++ classpath/gnu/java/security/OID.java	2006/07/13 23:29:28	1.8
@@ -71,6 +71,9 @@
   // Fields.
   // ------------------------------------------------------------------------
 
+  /* Serial version id for serialization. */
+  static final long serialVersionUID = 5722492029044597779L;
+  
   /**
    * The numeric ID structure.
    */
@@ -229,13 +232,6 @@
       }
   }
 
-  /**
-   * Our private constructor.
-   */
-  private OID()
-  {
-  }
-
   // Instance methods.
   // ------------------------------------------------------------------------
 
@@ -325,10 +321,16 @@
    */
   public Object clone()
   {
-    OID oid = new OID();
-    oid.components = this.components;
-    oid.strRep = this.strRep;
-    return oid;
+    try
+      {
+        return super.clone();
+      }
+    catch (CloneNotSupportedException cnse)
+      {
+        InternalError ie = new InternalError();
+        ie.initCause(cnse);
+        throw ie;
+      }
   }
 
   /* Nice idea, but possibly too expensive for whatever benefit it

signature.asc
Description: Questa è una parte del messaggio firmata digitalmente